format

googleapis · Sep 20, 2024 · fa8ef61 · fa8ef61
1 parent 7d87977
commit fa8ef61
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 9 deletions.
diff --git a/generator/internal/http_option_utils.cc b/generator/internal/http_option_utils.cc
@@ -263,7 +263,7 @@ void SetHttpQueryParameters(HttpExtensionInfo const& info,
       FormatQueryParameterCode(method, std::move(param_field_names));
 }
 
-HttpExtensionInfo ParseHttpExtension(google::api::HttpRule http_rule) {
+HttpExtensionInfo ParseHttpExtension(google::api::HttpRule const& http_rule) {
   HttpExtensionInfo info;
   switch (http_rule.pattern_case()) {
     case google::api::HttpRule::kGet:

diff --git a/generator/internal/http_option_utils.h b/generator/internal/http_option_utils.h
@@ -42,12 +42,8 @@ struct HttpExtensionInfo {
  * Parses the http extension providing resource routing info, if present,
  * for the provided method per AIP-4222. Output is also used for gRPC/HTTP
  * transcoding and REST transport.
- * Mixin method should use the target service's package and file names instead
- * of its own.
- * Mixin method' url, verb and body are overridden by the definition in target
- * service's YAML.
  */
-HttpExtensionInfo ParseHttpExtension(google::api::HttpRule http_rule);
+HttpExtensionInfo ParseHttpExtension(google::api::HttpRule const& http_rule);
 
 /**
  * Sets the following method_vars based on the provided parsed_http_info:

diff --git a/generator/internal/mixin_utils.cc b/generator/internal/mixin_utils.cc
@@ -120,7 +120,6 @@ std::unordered_map<std::string, google::api::HttpRule> GetMixinHttpOverrides(
       }
     }
 
-    // std::cout << http_rule.DebugString() << std::endl;
     http_rules[method_full_name] = std::move(http_rule);
   }
   return http_rules;

diff --git a/generator/internal/mixin_utils_test.cc b/generator/internal/mixin_utils_test.cc
@@ -26,9 +26,7 @@ using ::google::protobuf::FileDescriptor;
 using ::google::protobuf::ServiceDescriptor;
 using ::testing::AllOf;
 using ::testing::Contains;
-using ::testing::Eq;
 using ::testing::NotNull;
-using ::testing::Optional;
 
 auto constexpr kServiceConfigYaml = R"""(
 apis: