Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl_multi_wait might erroneously return CURLM_UNRECOVERABLE_POLL #11647

Closed
pitrou opened this issue May 18, 2023 · 1 comment · Fixed by #11649
Closed

curl_multi_wait might erroneously return CURLM_UNRECOVERABLE_POLL #11647

pitrou opened this issue May 18, 2023 · 1 comment · Fixed by #11649
Assignees
@coryan
Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@pitrou
Copy link
Contributor

pitrou commented May 18, 2023

In curl/curl#11135 it was determined that curl_multi_wait could sometimes return CURLM_UNRECOVERABLE_POLL on EINTR, while in most cases it turns EINTR into a success.

It is a plausible cause for a sporadic error that a user reported when using GCS from Arrow C++:
google::cloud::Status(UNKNOWN: Permanent error ReadObjectNotWrapped: WaitForHandles(): unexpected error code in curl_multi_*, [12]=Unrecoverable error in select/poll)
@pitrou pitrou added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 18, 2023
@coryan coryan added the api: storage Issues related to the Cloud Storage API. label May 18, 2023
@coryan coryan self-assigned this May 18, 2023
@coryan
Copy link
Contributor

coryan commented May 18, 2023

Thanks for the detailed analysis. Seems plausible and relatively easy to add a fix (or a workaround).

pitrou added a commit to pitrou/google-cloud-cpp that referenced this issue May 18, 2023
@pitrou
fix: workaround curl_multi_poll returning an error on EINTR
66ad916 
Fixes googleapis#11647.
@pitrou pitrou mentioned this issue May 18, 2023
Merged
pitrou added a commit to pitrou/google-cloud-cpp that referenced this issue May 18, 2023
@pitrou
fix: workaround curl_multi_poll returning an error on EINTR
e3e3cc3 
Fixes googleapis#11647.
@pitrou pitrou mentioned this issue May 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryan coryan

Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: workaround curl_multi_poll returning an error on EINTR pitrou/google-cloud-cpp
2 participants
@pitrou @coryan