Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): limit ModifyAckDeadlineRequest size #10032

Merged

Commits on Oct 11, 2022

  1. fix(pubsub): limit ModifyAckDeadlineRequest size

    Pub/Sub sets a quota of 512KB for `ModifyAckDeadlineRequest` messages.
    Theoretically we could have gone over that limit, for example, if the
    application had thousands of messages in memory, and we needed to
    extend their leases.  With this change such requests will be broken
    into multiple RPCs.
    
    It also sets a quota for `AcknowledgeRequest` messages, but always send
    a single `ack_id` in this case, there is no chance to go over the
    limit.
    coryan committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    e86c525 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    da469d9 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Configuration menu
    Copy the full SHA
    c608ca4 View commit details
    Browse the repository at this point in the history