Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): add migration service #10034

Merged
merged 3 commits into from
Oct 12, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 12, 2022

Fixes #10021


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Oct 12, 2022
@coryan coryan force-pushed the feat-bigquery-add-migration-library branch from f873222 to d193ba2 Compare October 12, 2022 13:18
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f873222ecadd008dde472eaa5d17ddb711e661c8

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: d193ba217c9e4640f4f1be2da6bfc06207795365

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 94.22% // Head: 94.22% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d69e588) compared to base (a4d7937).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10034   +/-   ##
=======================================
  Coverage   94.22%   94.22%           
=======================================
  Files        1522     1522           
  Lines      141402   141402           
=======================================
+ Hits       133232   133237    +5     
+ Misses       8170     8165    -5     
Impacted Files Coverage Δ
...le/cloud/storage/internal/curl_download_request.cc 89.29% <0.00%> (-0.67%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 96.59% <0.00%> (-0.57%) ⬇️
google/cloud/storage/internal/curl_handle.cc 77.90% <0.00%> (-0.56%) ⬇️
google/cloud/pubsub/samples/samples.cc 90.70% <0.00%> (-0.08%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.65% <0.00%> (+0.83%) ⬆️
...integration_tests/schema_admin_integration_test.cc 100.00% <0.00%> (+1.11%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️
google/cloud/internal/async_connection_ready.cc 93.61% <0.00%> (+4.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review October 12, 2022 13:52
@coryan coryan requested a review from a team as a code owner October 12, 2022 13:52
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to build the library?

add_library(
google_cloud_cpp_bigquery # cmake-format: sort

@coryan
Copy link
Contributor Author

coryan commented Oct 12, 2022

Do you want to build the library?

add_library(
google_cloud_cpp_bigquery # cmake-format: sort

picky picky picky ...

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: d69e588820c43d0d948b11907ccc9a1be65303e0

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan
Copy link
Contributor Author

coryan commented Oct 12, 2022

PTAL

@coryan coryan enabled auto-merge (squash) October 12, 2022 15:54
@coryan coryan merged commit 1bd280f into googleapis:main Oct 12, 2022
@coryan coryan deleted the feat-bigquery-add-migration-library branch October 12, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery Migration API: bigquerymigration.googleapis.com
3 participants