feat(pubsub): implement blocking publisher #10055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 94.23% // Head: 94.23% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10055 +/- ##
==========================================
- Coverage 94.23% 94.23% -0.01%
==========================================
Files 1537 1541 +4
Lines 142068 142183 +115
==========================================
+ Hits 133880 133981 +101
- Misses 8188 8202 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
coryan
force-pushed
the
feat-pubsub-blocking-publisher-draft
branch
from
115b655
to
a4765c5
Compare
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
dbolduc
approved these changes
Oct 18, 2022
| namespace google { | ||
| namespace cloud { | ||
| namespace pubsub { | ||
| GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN |
| * Publish messages to the Cloud Pub/Sub service. | ||
| * | ||
| * This class is used to publish messages to any given topic. It is intended | ||
| * for low-volume publishers: applications sending less than one message per |
There was a problem hiding this comment.
s/: applications/. Applications/
| * the `ok()` member function in the `StatusOr<T>` returns `true` then it | ||
| * contains the expected result. Please consult the #google::cloud::StatusOr | ||
| * documentation for more details. | ||
| * |
Some applications need a simple way to publish a small number of event to several topics. Or they need to publish with a low rate to many topics. The `pubsub::BlockingPublisher` client is more convenient for such applications than the existing `pubsub::Publisher`. The latter is optimized for high-throughput clients publishing to a single topic.
coryan
force-pushed
the
feat-pubsub-blocking-publisher-draft
branch
from
a4765c5
to
9b214a5
Compare
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some applications need a simple way to publish a small number of event to several topics. Or they need to publish with a low rate to many topics. The
pubsub::BlockingPublisherclient is more convenient for such applications than the existingpubsub::Publisher. The latter is optimized for high-throughput clients publishing to a single topic.Fixes #9301
This change is