Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl(common): classes to propagate error information #10259

Merged
merged 5 commits into from
Nov 18, 2022
Merged

impl(common): classes to propagate error information #10259

merged 5 commits into from
Nov 18, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Nov 16, 2022 •
edited
Loading

Part of the work for #5915

This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: b685de5fa7ebe42a1e242393ead9309c50884614

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: b5b5137e70dab8a5b67611a487875fa767204a22

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Nov 16, 2022 •
edited
Loading

Codecov Report

Base: 93.82% // Head: 93.81% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (09a4760) compared to base (57823e0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10259      +/-   ##
==========================================
- Coverage   93.82%   93.81%   -0.01%     
==========================================
  Files        1567     1570       +3     
  Lines      143798   143816      +18     
==========================================
+ Hits       134915   134925      +10     
- Misses       8883     8891       +8
Impacted Files Coverage Δ
google/cloud/internal/error_metadata.cc 100.00% <100.00%> (ø)
google/cloud/internal/error_metadata.h 100.00% <100.00%> (ø)
google/cloud/internal/error_metadata_test.cc 100.00% <100.00%> (ø)
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
...bigtable/examples/bigtable_hello_instance_admin.cc 81.00% <0.00%> (-2.00%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 88.29% <0.00%> (-1.01%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.82% <0.00%> (-0.34%) ⬇️
google/cloud/pubsub/samples/samples.cc 90.77% <0.00%> (-0.08%) ⬇️
...integration_tests/schema_admin_integration_test.cc 100.00% <0.00%> (+1.11%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review November 16, 2022 18:52
@coryan coryan requested a review from a team as a code owner November 16, 2022 18:52
@coryan coryan marked this pull request as draft November 16, 2022 22:29
@coryan coryan force-pushed the feat-oauth2-workload-identity-federation-pr2 branch from b5b5137 to 4e396cc Compare November 17, 2022 18:03
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 4e396cc7b46e600622b2bfe67303a51c3f309b16

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan changed the title impl(common): a class to propagate error information impl(common): classes to propagate error information Nov 17, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 4a8f91fd163881e4668207d582de0dfb47ce5945

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 7d637a7fb4fd3be45362dd930aa2c5b2a6499679

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

devbww
devbww reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@devbww devbww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure of the consensus on this yet, but ...

google/cloud/internal/error_metadata.h Outdated Show resolved Hide resolved
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 83421c31537e925cc74234fb3484ce6c6c89997b

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review November 17, 2022 23:29
@coryan
Copy link
Contributor Author

coryan commented Nov 18, 2022

PTAL

devbww
devbww reviewed Nov 18, 2022
View reviewed changes
google/cloud/internal/error_metadata.cc Outdated
Comment on lines 26 to 28
auto format = [](std::string* out, auto const& i) {
absl::StrAppend(out, i.first, "=", i.second);
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is the equivalent of absl::PairFormatter("=").

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@coryan coryan force-pushed the feat-oauth2-workload-identity-federation-pr2 branch from 83421c3 to 09a4760 Compare November 18, 2022 13:03
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 09a4760ee16bfb7e35f85d10c3b0d6e74b820053

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 98e6839 into googleapis:main Nov 18, 2022
@coryan coryan deleted the feat-oauth2-workload-identity-federation-pr2 branch November 18, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devbww devbww devbww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coryan @google-cloud-cpp-bot @devbww