Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(common): file-sourced subject tokens #10277

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Nov 18, 2022

To support external accounts credentials (aka BYOID) we need to support reading the subject token from a file. The file itself can be in either text or JSON format.

Part of the work for #5915


This change is Reviewable

To support external accounts credentials (aka BYOID) we need to support
reading the subject token from a file. The file itself can be in either
text or JSON format.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: c4e2f6862d5c8192cb0e12694c644819d42e649f

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 0603e585fad08d758655b94967101d443cc94fb4

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Base: 93.83% // Head: 93.84% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d2249f0) compared to base (2e80c50).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #10277    +/-   ##
========================================
  Coverage   93.83%   93.84%            
========================================
  Files        1573     1575     +2     
  Lines      144070   144310   +240     
========================================
+ Hits       135182   135421   +239     
- Misses       8888     8889     +1     
Impacted Files Coverage Δ
...oud/internal/external_account_token_source_file.cc 100.00% <100.00%> (ø)
...nternal/external_account_token_source_file_test.cc 100.00% <100.00%> (ø)
google/cloud/bigtable/async_read_stream_test.cc 97.32% <0.00%> (-0.67%) ⬇️
google/cloud/pubsub/samples/samples.cc 90.70% <0.00%> (-0.08%) ⬇️
google/cloud/internal/error_metadata.h 100.00% <0.00%> (ø)
...cloud/pubsub/internal/subscription_session_test.cc 97.98% <0.00%> (+0.16%) ⬆️
google/cloud/storage/parallel_upload.cc 98.62% <0.00%> (+0.34%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review November 19, 2022 04:50
@coryan coryan requested a review from a team as a code owner November 19, 2022 04:50
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: d2249f0f9e0ff0885358f3564b653c641b0f14f6

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 2cef6b6 into googleapis:main Nov 19, 2022
@coryan coryan deleted the feat-oauth2-workload-identity-federation-pr4 branch November 19, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants