Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: create build for external accounts integration #10287

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Nov 21, 2022

We need integration tests for external account support. The existing CI systems run on Google infrastructure and therefore not suitable for these tests. GitHub Actions are a bit underpowered, but if we keep the number of tests in this builds small, and the caches are warm, the builds are fast enough.

Part of the work for #5915


This change is Reviewable

We need integration tests for external account support. The
existing CI systems run on Google infrastructure and therefore not
suitable for these tests. GitHub Actions are a bit underpowered, but
if we keep the number of tests in this builds small, and the caches are
warm, the builds are fast enough.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 22701df2d136025e32a1bccb1aa54c5d60c06d73

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 93.84% // Head: 93.84% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (22701df) compared to base (94285ba).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10287   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files        1577     1577           
  Lines      144344   144344           
=======================================
+ Hits       135456   135459    +3     
+ Misses       8888     8885    -3     
Impacted Files Coverage Δ
google/cloud/pubsub/subscriber_connection_test.cc 97.81% <0.00%> (-0.55%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 89.63% <0.00%> (ø)
...cloud/pubsub/internal/subscription_session_test.cc 98.15% <0.00%> (+0.16%) ⬆️
...integration_tests/schema_admin_integration_test.cc 100.00% <0.00%> (+1.11%) ⬆️
google/cloud/internal/async_connection_ready.cc 93.61% <0.00%> (+4.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review November 21, 2022 20:15
@coryan coryan requested a review from a team as a code owner November 21, 2022 20:15
key: |
vcpkg-${{ steps.vcpkg-version.outputs.version }}-${{ hashFiles('vcpkg.json') }}
restore-keys: |
vcpkg-${{ steps.vcpkg-version.outputs.version }}-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@coryan coryan merged commit d46656c into googleapis:main Nov 22, 2022
@coryan coryan deleted the feat-oauth2-workload-identity-federation-pr7 branch November 22, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants