Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: another pass on authentication components #10300

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Nov 23, 2022

I made a pass trying to assume less about what the reader may know about authentication. Motivated by the incorrect magic for numbered items in Doxygen.


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 6758365ae7948b57cae901d873522187c9c3eaa6

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 93.84% // Head: 93.84% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c10cd5d) compared to base (427350f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10300   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files        1592     1592           
  Lines      144868   144868           
=======================================
+ Hits       135956   135957    +1     
+ Misses       8912     8911    -1     
Impacted Files Coverage Δ
google/cloud/pubsub/subscriber_connection_test.cc 98.78% <0.00%> (-1.22%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.49% <0.00%> (-0.17%) ⬇️
...torage/examples/storage_service_account_samples.cc 97.64% <0.00%> (+0.58%) ⬆️
google/cloud/internal/async_connection_ready.cc 93.61% <0.00%> (+4.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review November 23, 2022 21:45
@coryan coryan requested a review from a team as a code owner November 23, 2022 21:45
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @coryan)


google/cloud/doc/guac.dox line 39 at r1 (raw file):

As we mentioned in passing, authentication supports both user accounts and
service accounts. These are referred as "principals". User accounts represent
a developers, administrator, or any other person who interacts with GCP

s/^a// or s/developers/developer

Code quote:

a developers

I made a pass trying to assume less about what the reader may know about
authentication. Motivated by the incorrect magic for numbered items in
Doxygen.
@coryan coryan force-pushed the doc-another-pass-on-guac-dox branch from 6758365 to c10cd5d Compare November 24, 2022 14:41
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: c10cd5dfe879d520785b06769f0211e91f3770ce

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 356b902 into googleapis:main Nov 28, 2022
@coryan coryan deleted the doc-another-pass-on-guac-dox branch November 28, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants