Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: success predicates for rest_internal::RestResponse #10370

Merged
merged 2 commits into from
Dec 5, 2022
Merged

refactor: success predicates for rest_internal::RestResponse #10370

merged 2 commits into from
Dec 5, 2022

Commits on Dec 5, 2022

  1. refactor: success predicates for rest_internal::RestResponse 

    We often need to determine if a `RestResponse` contains a successful
HTTP response or an error.  These helpers make the code easier to read
and provide more consistent treatment of `RestResponse`. Callers that
deviate from the standard success/failure codes can write their own
functions (e.g., GCS treats 308 as "success" in some RPCs).
    @coryan
    coryan committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    5980fff View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @coryan
    coryan committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    53d306b View commit details
    Browse the repository at this point in the history