Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split IAMCredentials GenerateAccessToken() #10378

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 5, 2022

We will need to parse the GenerateAccessToken() response in the external account implementation. This splits the parsing to a standalone function.

Part of the work for #5915


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 40bbc0a76654c39e914bd665eeb1bc4b206c2a25

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 93.86% // Head: 93.86% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (bfb006b) compared to base (2546d44).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10378      +/-   ##
==========================================
- Coverage   93.86%   93.86%   -0.01%     
==========================================
  Files        1600     1600              
  Lines      145412   145429      +17     
==========================================
+ Hits       136497   136501       +4     
- Misses       8915     8928      +13     
Impacted Files Coverage Δ
...oud/internal/oauth2_minimal_iam_credentials_rest.h 100.00% <ø> (ø)
...ud/internal/oauth2_minimal_iam_credentials_rest.cc 72.36% <100.00%> (+4.67%) ⬆️
...ternal/oauth2_minimal_iam_credentials_rest_test.cc 100.00% <100.00%> (ø)
...ogle/cloud/spanner/testing/pick_random_instance.cc 84.21% <0.00%> (-7.90%) ⬇️
...bigtable/examples/bigtable_hello_instance_admin.cc 81.00% <0.00%> (-2.00%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.82% <0.00%> (-0.84%) ⬇️
google/cloud/bigtable/async_read_stream_test.cc 97.32% <0.00%> (-0.67%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 89.29% <0.00%> (-0.34%) ⬇️
google/cloud/storage/parallel_upload.cc 98.62% <0.00%> (+0.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan force-pushed the feat-oauth2-workload-identity-federation-pr15 branch from 40bbc0a to e99f22f Compare December 6, 2022 01:42
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: e99f22f47b4dd5d2dfffefda164fb0441031ab9d

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review December 6, 2022 02:11
@coryan coryan requested a review from a team as a code owner December 6, 2022 02:11
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

We will need to parse the `GenerateAccessToken()` response in the
external account implementation. This splits the parsing to a standalone
function.
@coryan coryan force-pushed the feat-oauth2-workload-identity-federation-pr15 branch from e99f22f to adda3e7 Compare December 6, 2022 03:31
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: adda3e7d92f1cbcd5302c474eb8d33c12f8291d9

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan enabled auto-merge (squash) December 6, 2022 04:21
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: bfb006b97689f51b57530c5de344de4918951862

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 4da3a24 into googleapis:main Dec 6, 2022
@coryan coryan deleted the feat-oauth2-workload-identity-federation-pr15 branch December 6, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants