-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split IAMCredentials GenerateAccessToken()
#10378
refactor: split IAMCredentials GenerateAccessToken()
#10378
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.86% // Head: 93.86% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10378 +/- ##
==========================================
- Coverage 93.86% 93.86% -0.01%
==========================================
Files 1600 1600
Lines 145412 145429 +17
==========================================
+ Hits 136497 136501 +4
- Misses 8915 8928 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
40bbc0a
to
e99f22f
Compare
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @coryan)
We will need to parse the `GenerateAccessToken()` response in the external account implementation. This splits the parsing to a standalone function.
e99f22f
to
adda3e7
Compare
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
We will need to parse the
GenerateAccessToken()
response in the external account implementation. This splits the parsing to a standalone function.Part of the work for #5915
This change is