impl: support external accounts mapping #10391
Conversation
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.86% // Head: 93.84% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10391 +/- ##
==========================================
- Coverage 93.86% 93.84% -0.03%
==========================================
Files 1601 1601
Lines 145620 145676 +56
==========================================
+ Hits 136693 136715 +22
- Misses 8927 8961 +34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
coryan
force-pushed
the
feat-oauth2-workload-identity-federation-pr17
branch
from
a346cd9
to
1dc7285
Compare
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
coryan
force-pushed
the
feat-oauth2-workload-identity-federation-pr17
branch
from
1dc7285
to
0f23ebe
Compare
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
| #include "absl/memory/memory.h" | ||
| #include <grpcpp/security/credentials.h> |
There was a problem hiding this comment.
are we relying on the grpc::experimental namespace being included by the grpc header? should we define it ourselves, just in case?
namespace grpc::experimental {}There was a problem hiding this comment.
No. This was just because I wanted to preempt any IWYU questions. We should not be reopening "other" namespaces, and there are plenty of grpc::experimental things
There was a problem hiding this comment.
ok, I just worry that we wouldn't control whether using namespace grpc::experimental; breaks one day, because the namespace is not defined. 🤷
There was a problem hiding this comment.
I expect we will get a PR to update gRPC and detect the breakage early, before our customers with high likelihood.
coryan
force-pushed
the
feat-oauth2-workload-identity-federation-pr17
branch
from
0f23ebe
to
69a1bd4
Compare
Create the class derived from `google::cloud::Credentials` that will represent external accounts. These classes are mapped to the implementation using `google::cloud::internal::CredentialsVisitor`, which now supports external accounts. I change the integration test for external accounts to use the credentials to make a GCS request.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
coryan
force-pushed
the
feat-oauth2-workload-identity-federation-pr17
branch
from
69a1bd4
to
404174b
Compare
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Create the class derived from
google::cloud::Credentialsthat will represent external accounts. These classes are mapped to the implementation usinggoogle::cloud::internal::CredentialsVisitor, which now supports external accounts. I change the integration test for external accounts to use the credentials to make a GCS request.Part of the work for #5915
This change is