Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(oauth2): use client factory for impersonation credentials #10416

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 9, 2022

This will make things easier to test, I am thinking of oauth2_internal::MapCredentials() or oauth2_internal::GoogleDefaultCredentials(), which are not easy to mock at this time.

Part of the work for #5915


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: da54e49ea3173ab1cb01b3ebca58ccb743807b60

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 93.85% // Head: 93.86% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b344dd2) compared to base (92d7528).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10416   +/-   ##
=======================================
  Coverage   93.85%   93.86%           
=======================================
  Files        1610     1610           
  Lines      145821   145829    +8     
=======================================
+ Hits       136866   136885   +19     
+ Misses       8955     8944   -11     
Impacted Files Coverage Δ
...oud/internal/oauth2_minimal_iam_credentials_rest.h 100.00% <ø> (ø)
.../oauth2_impersonate_service_account_credentials.cc 100.00% <100.00%> (ø)
...ud/internal/oauth2_minimal_iam_credentials_rest.cc 94.59% <100.00%> (+22.22%) ⬆️
...ternal/oauth2_minimal_iam_credentials_rest_test.cc 100.00% <100.00%> (ø)
google/cloud/internal/unified_rest_credentials.cc 74.07% <100.00%> (+0.48%) ⬆️
...ernal/unified_rest_credentials_integration_test.cc 96.39% <100.00%> (+0.03%) ⬆️
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
...bigtable/examples/bigtable_hello_instance_admin.cc 81.00% <0.00%> (-2.00%) ⬇️
google/cloud/storage/internal/curl_handle.cc 77.90% <0.00%> (-0.56%) ⬇️
google/cloud/completion_queue_test.cc 97.13% <0.00%> (-0.20%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: b344dd2a925286def5c838050e50e7edefe9165a

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review December 9, 2022 21:54
@coryan coryan requested a review from a team as a code owner December 9, 2022 21:54
@coryan coryan merged commit 9891846 into googleapis:main Dec 9, 2022
@coryan coryan deleted the impl-oauth2-use-http-client-factory-for-impersonation-credentials branch December 9, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants