Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): options for Make*Credentials() #10417

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 9, 2022

This changes all the g::c::Credential factory functions to accept a g::c::Options parameter. At this time this can be used to initialize logging in the credential layer, but eventually it could gain


This change is Reviewable

This changes all the `g::c::Credential` factory functions to accept a
`g::c::Options` parameter. At this time this can be used to initialize
logging in the credential layer, but eventually it could gain
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: cda67539d3f2db713ba8f94033324389abc74a5b

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 93.85% // Head: 93.85% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (32da6fd) compared to base (92d7528).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10417      +/-   ##
==========================================
- Coverage   93.85%   93.85%   -0.01%     
==========================================
  Files        1610     1610              
  Lines      145821   145822       +1     
==========================================
  Hits       136866   136866              
- Misses       8955     8956       +1     
Impacted Files Coverage Δ
google/cloud/credentials.cc 100.00% <100.00%> (ø)
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
...bigtable/examples/bigtable_hello_instance_admin.cc 81.00% <0.00%> (-2.00%) ⬇️
google/cloud/storage/internal/curl_handle.cc 77.90% <0.00%> (-0.56%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 89.29% <0.00%> (-0.34%) ⬇️
google/cloud/completion_queue_test.cc 97.13% <0.00%> (-0.20%) ⬇️
google/cloud/pubsub/samples/samples.cc 90.85% <0.00%> (+0.07%) ⬆️
...ud/spanner/integration_tests/client_stress_test.cc 84.86% <0.00%> (+0.65%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.66% <0.00%> (+0.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review December 9, 2022 21:55
@coryan coryan requested a review from a team as a code owner December 9, 2022 21:55
Copy link
Contributor

@devbww devbww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description: s/eventually it could gain$/eventually it could gain <something>./

@@ -82,8 +83,12 @@ struct UnifiedCredentialsOption {
* and sometimes even errors.
*
* @ingroup guac
*
* @param opts optional configuration values. Note that the effect of these
* parameters depends on the underlying transport. For example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/$/,/ et seq.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.

@coryan coryan enabled auto-merge (squash) December 9, 2022 22:24
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 32da6fdbad4d2f1d4d0a65724229f9577cf9f6e9

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit e69ab23 into googleapis:main Dec 10, 2022
@coryan coryan deleted the feat-options-for-credential-factory-functions branch December 10, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants