Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(oauth2): parsing for AWS subject token source #10432

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 13, 2022

AWS has a fairly complicated protocol to obtain subject token. This PR just introduces parsing from the JSON object configuration to a C++ structure. Future PRs will use this structure to drive the HTTP flows required to get these credentials.

Part of the work for #5915


This change is Reviewable

AWS has a fairly complicated protocol to obtain subject token. This PR
just introduces parsing from the JSON object configuration to a C++
structure. Future PRs will use this structure to drive the HTTP flows
required to get these credentials.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 8bc5bbf88ce0ae0cdbf730666bab1ac3f721909d

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 93.89% // Head: 93.89% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (3cac3ca) compared to base (80e686d).
Patch coverage: 98.63% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10432      +/-   ##
==========================================
- Coverage   93.89%   93.89%   -0.01%     
==========================================
  Files        1610     1612       +2     
  Lines      146183   146330     +147     
==========================================
+ Hits       137257   137391     +134     
- Misses       8926     8939      +13     
Impacted Files Coverage Δ
...loud/internal/external_account_token_source_aws.cc 93.93% <93.93%> (ø)
...internal/external_account_token_source_aws_test.cc 100.00% <100.00%> (ø)
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 97.05% <0.00%> (-2.95%) ⬇️
...torage/examples/storage_service_account_samples.cc 96.47% <0.00%> (-1.18%) ⬇️
...integration_tests/schema_admin_integration_test.cc 98.88% <0.00%> (-1.12%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.99% <0.00%> (-0.67%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 84.21% <0.00%> (-0.66%) ⬇️
google/cloud/storage/parallel_upload.cc 98.28% <0.00%> (-0.35%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 89.29% <0.00%> (-0.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review December 13, 2022 19:52
@coryan coryan requested a review from a team as a code owner December 13, 2022 19:52
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 3cac3ca68dcaee27b1a452c7b7a525ac6bb9b0db

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan enabled auto-merge (squash) December 13, 2022 20:45
@coryan coryan merged commit 2e70cd9 into googleapis:main Dec 13, 2022
@coryan coryan deleted the feat-oauth2-workload-identity-federation-pr21 branch December 13, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants