Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(oauth2): validate some URLs in AWS external account #10448

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 15, 2022

The spec (aip.dev/auth/4117) requires validation for some URL fields in the AWS external account configuration.

Part of the work for #5915


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 6715b77f2f07b3f56987fb1e791252218d33c64a

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 93.87% // Head: 93.87% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (1941a11) compared to base (b80a5f2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10448   +/-   ##
=======================================
  Coverage   93.87%   93.87%           
=======================================
  Files        1612     1612           
  Lines      146520   146572   +52     
=======================================
+ Hits       137540   137593   +53     
+ Misses       8980     8979    -1     
Impacted Files Coverage Δ
...loud/internal/external_account_token_source_aws.cc 93.38% <100.00%> (+0.93%) ⬆️
...internal/external_account_token_source_aws_test.cc 99.72% <100.00%> (+0.03%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 97.05% <0.00%> (-2.95%) ⬇️
google/cloud/internal/async_connection_ready.cc 93.61% <0.00%> (+4.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review December 15, 2022 17:38
@coryan coryan requested a review from a team as a code owner December 15, 2022 17:38
@coryan coryan changed the title impl(oauth2): valid some URLs in AWS external account impl(oauth2): validate some URLs in AWS external account Dec 15, 2022
The spec (aip.dev/auth/4117) requires validation for some URL fields in
the AWS external account configuration.
@coryan coryan force-pushed the feat-oauth2-workload-identity-federation-pr26 branch from 6715b77 to 1941a11 Compare December 15, 2022 18:27
@coryan coryan enabled auto-merge (squash) December 15, 2022 18:28
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 1941a116855de095ba9d11d259501cbb664c6251

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 432696a into googleapis:main Dec 15, 2022
@coryan coryan deleted the feat-oauth2-workload-identity-federation-pr26 branch December 15, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants