-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl(oauth2): create AWS V4 signed request #10452
impl(oauth2): create AWS V4 signed request #10452
Conversation
Create the AWS V4 signed request as a JSON object because it is easier to test. In the actual implementation this becomes a string, that is then URL-encoded (yikes!) and passed to Google's Security Token Service.
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.91% // Head: 93.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10452 +/- ##
=======================================
Coverage 93.91% 93.91%
=======================================
Files 1614 1614
Lines 146618 146707 +89
=======================================
+ Hits 137700 137786 +86
- Misses 8918 8921 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @coryan)
google/cloud/internal/external_account_token_source_aws.h
line 113 at r1 (raw file):
ExternalAccountTokenSourceAwsSecrets const& secrets, std::chrono::system_clock::time_point now, std::string const& target, bool debug);
Maybe default this to false?
Code quote:
bool debug
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Create the AWS V4 signed request as a JSON object because it is easier to test. In the actual implementation this becomes a string, that is then URL-encoded (yikes!) and passed to Google's Security Token Service.
Part of the work for #5915
This change is