Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(oauth2): create AWS V4 signed request #10452

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 16, 2022

Create the AWS V4 signed request as a JSON object because it is easier to test. In the actual implementation this becomes a string, that is then URL-encoded (yikes!) and passed to Google's Security Token Service.

Part of the work for #5915


This change is Reviewable

Create the AWS V4 signed request as a JSON object because it is
easier to test. In the actual implementation this becomes a string, that
is then URL-encoded (yikes!) and passed to Google's Security Token
Service.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f4c68dcbb63ef2471784d3e33711932452b51f64

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 93.91% // Head: 93.91% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b17e77c) compared to base (03cd5fa).
Patch coverage: 98.87% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10452   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files        1614     1614           
  Lines      146618   146707   +89     
=======================================
+ Hits       137700   137786   +86     
- Misses       8918     8921    +3     
Impacted Files Coverage Δ
...internal/external_account_token_source_aws_test.cc 99.51% <98.11%> (-0.21%) ⬇️
...loud/internal/external_account_token_source_aws.cc 94.90% <100.00%> (+1.51%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 81.00% <0.00%> (-2.00%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 98.78% <0.00%> (-1.22%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 88.29% <0.00%> (-1.01%) ⬇️
...sub/internal/batching_publisher_connection_test.cc 99.44% <0.00%> (-0.19%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.99% <0.00%> (-0.17%) ⬇️
google/cloud/pubsub/samples/samples.cc 87.93% <0.00%> (+0.07%) ⬆️
google/cloud/storage/parallel_upload.cc 98.62% <0.00%> (+0.34%) ⬆️
google/cloud/bigtable/async_read_stream_test.cc 97.99% <0.00%> (+0.66%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review December 16, 2022 03:53
@coryan coryan requested a review from a team as a code owner December 16, 2022 03:53
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @coryan)


google/cloud/internal/external_account_token_source_aws.h line 113 at r1 (raw file):

    ExternalAccountTokenSourceAwsSecrets const& secrets,
    std::chrono::system_clock::time_point now, std::string const& target,
    bool debug);

Maybe default this to false?

Code quote:

bool debug

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: b17e77c3e9f722edf1e21f4768c0e1426f4b4aff

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 9893009 into googleapis:main Dec 16, 2022
@coryan coryan deleted the feat-oauth2-workload-identity-federation-pr27 branch December 16, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants