Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: relocate golden files #10454

Merged
merged 7 commits into from
Dec 17, 2022
Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Dec 16, 2022

Motivated by #10170

Move the golden files from generator/integration_tests/golden -> generator/integration_tests/golden/v1.

While this is not necessary to test forwarding headers, I think it is best that our golden files reflect our real libraries. (That is, we could leave the golden files where they are and generate forwarding headers in generator/integration_tests/some_random_directory/.... it would work fine, but it would be confusing).

The PR is broken into atomic commits, so hopefully that makes things easier to review.

In the update unit tests commit, I ran the following:

cd generator/integration_tests/tests
sed -i 's;golden/;golden/v1/;' *
sed -i 's;golden::;golden_v1::;' *
sed -i 's;golden_internal::;golden_v1_internal::;' *
sed -i 's;golden_mocks::;golden_v1_mocks::;' *
sed -i 's;namespace golden;namespace golden_v1;' *
sed -i 's;namespace golden_internal;namespace golden_v1_internal;' *
sed -i 's;namespace golden_mocks;namespace golden_v1_mocks;' *

This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 125aa8a72af23267e046a0e077f1d96f631e437b

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 93.91% // Head: 93.91% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (125aa8a) compared to base (0bea867).
Patch coverage: 97.74% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10454   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files        1614     1612    -2     
  Lines      146738   146708   -30     
=======================================
- Hits       137805   137782   -23     
+ Misses       8933     8926    -7     
Impacted Files Coverage Δ
...tion_tests/golden/v1/golden_kitchen_sink_client.cc 80.68% <ø> (ø)
...ation_tests/golden/v1/golden_kitchen_sink_client.h 100.00% <ø> (ø)
...n_tests/golden/v1/golden_kitchen_sink_connection.h 100.00% <ø> (ø)
...lden_kitchen_sink_connection_idempotency_policy.cc 71.42% <ø> (ø)
...ation_tests/golden/v1/golden_thing_admin_client.cc 98.10% <ø> (ø)
...ration_tests/golden/v1/golden_thing_admin_client.h 100.00% <ø> (ø)
...on_tests/golden/v1/golden_thing_admin_connection.h 100.00% <ø> (ø)
...olden_thing_admin_connection_idempotency_policy.cc 95.23% <ø> (ø)
.../v1/internal/golden_kitchen_sink_auth_decorator.cc 70.12% <ø> (ø)
...n/v1/internal/golden_kitchen_sink_auth_decorator.h 100.00% <ø> (ø)
... and 91 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc marked this pull request as ready for review December 16, 2022 21:50
@dbolduc dbolduc requested a review from a team as a code owner December 16, 2022 21:50
@dbolduc dbolduc merged commit 00764bf into googleapis:main Dec 17, 2022
@dbolduc dbolduc deleted the relocate-golden-files branch December 17, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants