-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: relocate golden files #10454
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.91% // Head: 93.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10454 +/- ##
=======================================
Coverage 93.91% 93.91%
=======================================
Files 1614 1612 -2
Lines 146738 146708 -30
=======================================
- Hits 137805 137782 -23
+ Misses 8933 8926 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Motivated by #10170
Move the golden files from
generator/integration_tests/golden
->generator/integration_tests/golden/v1
.While this is not necessary to test forwarding headers, I think it is best that our golden files reflect our real libraries. (That is, we could leave the golden files where they are and generate forwarding headers in
generator/integration_tests/some_random_directory/
.... it would work fine, but it would be confusing).The PR is broken into atomic commits, so hopefully that makes things easier to review.
In the
update unit tests
commit, I ran the following:This change is