Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(oauth2): subject token source for AWS credentials #10457

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 19, 2022

Part of the work for #5915


This change is Reviewable

@coryan coryan changed the title impl(oauth2); subject token source for AWS credentials impl(oauth2): subject token source for AWS credentials Dec 19, 2022
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 3703d19b15623d7fed86cb6547eb975d72a64309

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 93.91% // Head: 93.91% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5ccf93a) compared to base (00764bf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #10457    +/-   ##
========================================
  Coverage   93.91%   93.91%            
========================================
  Files        1612     1612            
  Lines      146702   146808   +106     
========================================
+ Hits       137776   137879   +103     
- Misses       8926     8929     +3     
Impacted Files Coverage Δ
...loud/internal/external_account_token_source_aws.cc 96.55% <100.00%> (+1.64%) ⬆️
...internal/external_account_token_source_aws_test.cc 99.60% <100.00%> (+0.08%) ⬆️
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
...bigtable/examples/bigtable_hello_instance_admin.cc 81.00% <0.00%> (-2.00%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 88.29% <0.00%> (-1.01%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.82% <0.00%> (-0.84%) ⬇️
google/cloud/pubsub/samples/samples.cc 87.93% <0.00%> (+0.07%) ⬆️
...le/cloud/spanner/database_admin_connection_test.cc 99.70% <0.00%> (+0.19%) ⬆️
google/cloud/spanner/database_admin_connection.cc 85.59% <0.00%> (+0.28%) ⬆️
...torage/examples/storage_service_account_samples.cc 97.64% <0.00%> (+0.58%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review December 19, 2022 17:14
@coryan coryan requested a review from a team as a code owner December 19, 2022 17:14
@coryan coryan force-pushed the feat-oauth2-workload-identity-federation-pr29 branch from 3703d19 to 5ccf93a Compare December 19, 2022 18:14
@coryan coryan enabled auto-merge (squash) December 19, 2022 18:15
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 5ccf93a4a92dc8f28423c2aadb3d55dc6ea5e8d8

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit f8c3802 into googleapis:main Dec 19, 2022
@coryan coryan deleted the feat-oauth2-workload-identity-federation-pr29 branch December 19, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants