Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(generator): backwards compat using declarations are deprecated #10466

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Dec 20, 2022

Part of the work for #10170

In response to: #10463 (comment)


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 18b87a54a51607e6337f6faa48bb44cb6365ce6b

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 93.87% // Head: 93.88% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (18b87a5) compared to base (b191e83).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10466   +/-   ##
=======================================
  Coverage   93.87%   93.88%           
=======================================
  Files        1624     1624           
  Lines      147462   147462           
=======================================
+ Hits       138436   138449   +13     
+ Misses       9026     9013   -13     
Impacted Files Coverage Δ
generator/internal/forwarding_client_generator.cc 0.00% <ø> (ø)
...erator/internal/forwarding_connection_generator.cc 0.00% <ø> (ø)
...nternal/forwarding_idempotency_policy_generator.cc 0.00% <ø> (ø)
...r/internal/forwarding_mock_connection_generator.cc 0.00% <ø> (ø)
generator/internal/forwarding_options_generator.cc 0.00% <ø> (ø)
...sub/internal/batching_publisher_connection_test.cc 99.62% <0.00%> (+0.18%) ⬆️
google/cloud/storage/parallel_upload.cc 98.62% <0.00%> (+0.34%) ⬆️
...ud/spanner/integration_tests/client_stress_test.cc 84.86% <0.00%> (+0.65%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.66% <0.00%> (+0.66%) ⬆️
google/cloud/bigtable/async_read_stream_test.cc 97.99% <0.00%> (+0.66%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc marked this pull request as ready for review December 20, 2022 18:51
@dbolduc dbolduc requested a review from a team as a code owner December 20, 2022 18:51
@dbolduc dbolduc merged commit b0a30f0 into googleapis:main Dec 20, 2022
@dbolduc dbolduc deleted the forwarding-headers-deprecated-tags branch December 20, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants