Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate protos #10486

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jan 3, 2023

This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 44d370bd51783f916e105a7a42f1c2533dbe1964

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 93.94% // Head: 93.94% // No change to project coverage 👍

Coverage data is based on head (713022a) compared to base (07d51b6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10486   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files        1626     1626           
  Lines      147457   147457           
=======================================
  Hits       138524   138524           
  Misses       8933     8933           
Impacted Files Coverage Δ
...integration_tests/schema_admin_integration_test.cc 98.88% <0.00%> (-1.12%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 88.29% <0.00%> (-1.01%) ⬇️
google/cloud/completion_queue_test.cc 97.13% <0.00%> (-0.20%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 84.86% <0.00%> (+0.65%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.49% <0.00%> (+0.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review January 4, 2023 00:07
@coryan coryan requested a review from a team as a code owner January 4, 2023 00:07
@coryan coryan enabled auto-merge (squash) January 4, 2023 13:57
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 713022a6f81ca0e862f3b885a37507118998c8fa

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 77fa64e into googleapis:main Jan 4, 2023
@coryan coryan deleted the cleanup-remove-duplicate-protos branch January 4, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants