fix(common): fewer spurious warnings in the log #10811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a streaming RPC is cancelled we should expect the final status of the RPC to be either kOk, or kCancelled. Both are normal outcomes in this case and do not deserve a warning in the log.
Codecov ReportBase: 93.65% // Head: 93.65% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10811 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 1713 1713
Lines 153982 154017 +35
=======================================
+ Hits 144208 144245 +37
+ Misses 9774 9772 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
scotthart
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @coryan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a streaming RPC is cancelled we should expect the final status of the RPC to be either kOk, or kCancelled. Both are normal outcomes in this case and do not deserve a warning in the log.
This change is