Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(asset): versioned clients #10863

Merged
merged 7 commits into from
Feb 21, 2023
Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Feb 20, 2023

Part of the work for #10170

Note that this PR has an extra step to manually edit .typos.toml


This change is Reviewable

@product-auto-label product-auto-label bot added the api: cloudasset Issues related to the Cloud Asset Inventory API. label Feb 20, 2023
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 93.65% // Head: 93.66% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (af245fc) compared to base (6523f91).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10863   +/-   ##
=======================================
  Coverage   93.65%   93.66%           
=======================================
  Files        1715     1715           
  Lines      154442   154442           
=======================================
+ Hits       144650   144653    +3     
+ Misses       9792     9789    -3     
Impacted Files Coverage Δ
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 97.05% <0.00%> (-2.95%) ⬇️
google/cloud/internal/timer_queue.cc 96.10% <0.00%> (-1.30%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 98.78% <0.00%> (-1.22%) ⬇️
google/cloud/bigtable/async_read_stream_test.cc 97.32% <0.00%> (-0.67%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 88.62% <0.00%> (-0.34%) ⬇️
google/cloud/pubsub/samples/samples.cc 87.01% <0.00%> (-0.15%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.83% <0.00%> (+0.16%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️
google/cloud/spanner/internal/session_pool.cc 90.20% <0.00%> (+2.09%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc marked this pull request as ready for review February 21, 2023 00:18
@dbolduc dbolduc requested a review from a team as a code owner February 21, 2023 00:18
@dbolduc dbolduc merged commit c00fbc4 into googleapis:main Feb 21, 2023
@dbolduc dbolduc deleted the relocate-asset branch February 21, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudasset Issues related to the Cloud Asset Inventory API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants