Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(logging): versioned clients #10926

Merged
merged 5 commits into from
Feb 23, 2023
Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Feb 22, 2023

Part of the work for #10170

NOTE: This one is not like the others!! There are manual updates to the build files, to use GLOBs.

There is a TODO for writing a handwritten stream updater method.... which implies handwritten tests.... which implies we might not want globs...... but let's just deal with that reality later.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: logging Issues related to the Cloud Logging API. label Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 93.65% // Head: 93.65% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (84f7e7e) compared to base (3a1e6ee).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10926      +/-   ##
==========================================
- Coverage   93.65%   93.65%   -0.01%     
==========================================
  Files        1717     1717              
  Lines      154871   154871              
==========================================
- Hits       145049   145045       -4     
- Misses       9822     9826       +4     
Impacted Files Coverage Δ
...te/integration_tests/publisher_integration_test.cc 92.10% <0.00%> (-6.58%) ⬇️
google/cloud/internal/timer_queue.cc 96.10% <0.00%> (-1.30%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.66% <0.00%> (ø)
google/cloud/pubsub/samples/samples.cc 87.01% <0.00%> (+0.07%) ⬆️
...le/cloud/storage/internal/curl_download_request.cc 89.29% <0.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc marked this pull request as ready for review February 22, 2023 22:51
@dbolduc dbolduc requested a review from a team as a code owner February 22, 2023 22:51
@dbolduc dbolduc merged commit 8640260 into googleapis:main Feb 23, 2023
@dbolduc dbolduc deleted the relocate-logging branch February 23, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants