Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: some more versioned clients #10931

Merged
merged 5 commits into from
Feb 23, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Feb 23, 2023

Part of the work for #10170

  • privateca
  • profiler
  • recommender
  • redis
  • resourcesettings

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 93.64% // Head: 93.64% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (397a401) compared to base (8c5eb6a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10931   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files        1717     1717           
  Lines      154933   154933           
=======================================
+ Hits       145090   145092    +2     
+ Misses       9843     9841    -2     
Impacted Files Coverage Δ
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 88.62% <0.00%> (-0.34%) ⬇️
google/cloud/pubsub/samples/samples.cc 87.01% <0.00%> (+0.07%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 97.99% <0.00%> (+0.16%) ⬆️
...le/cloud/internal/default_completion_queue_impl.cc 97.15% <0.00%> (+0.56%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc marked this pull request as ready for review February 23, 2023 05:19
@dbolduc dbolduc requested a review from a team as a code owner February 23, 2023 05:19
@dbolduc dbolduc merged commit e283e4b into googleapis:main Feb 23, 2023
@dbolduc dbolduc deleted the relocate-privateca branch February 23, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants