Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iam): versioned v1 clients #10944

Merged
merged 5 commits into from
Feb 24, 2023
Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Feb 23, 2023

Part of the work for #10170

This one was a mixed library, that also has a handwritten backwards compatibility retry_traits.h.

I am not going to update the samples to use versioned clients yet. I think cloud docs use region tags at HEAD, so it would be wise for us to wait for a release with the versioned clients before updating the samples.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: iam Issues related to the Identity and Access Management API. label Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 93.64% // Head: 93.64% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ca4ef1a) compared to base (2ec044f).
Patch has no changes to coverable lines.

❗ Current head ca4ef1a differs from pull request most recent head dd28a3a. Consider uploading reports for the commit dd28a3a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10944   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files        1717     1717           
  Lines      154878   154890   +12     
=======================================
+ Hits       145037   145054   +17     
+ Misses       9841     9836    -5     
Impacted Files Coverage Δ
google/cloud/pubsub/samples/iam_samples.cc 94.70% <ø> (ø)
...le/cloud/storage/internal/curl_download_request.cc 88.62% <0.00%> (-0.34%) ⬇️
google/cloud/spanner/read_partition.h 100.00% <0.00%> (ø)
google/cloud/spanner/samples/samples.cc 62.27% <0.00%> (ø)
google/cloud/spanner/internal/session_pool.cc 88.11% <0.00%> (ø)
google/cloud/spanner/client.cc 98.15% <0.00%> (+0.10%) ⬆️
google/cloud/spanner/read_partition.cc 85.00% <0.00%> (+0.38%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.49% <0.00%> (+0.50%) ⬆️
...ud/spanner/integration_tests/client_stress_test.cc 84.86% <0.00%> (+0.65%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc marked this pull request as ready for review February 23, 2023 22:22
@dbolduc dbolduc requested a review from a team as a code owner February 23, 2023 22:22
@snippet-bot
Copy link

snippet-bot bot commented Feb 23, 2023

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@dbolduc dbolduc marked this pull request as draft February 23, 2023 22:26
@dbolduc
Copy link
Member Author

dbolduc commented Feb 23, 2023

Oops, I messed up some of the handwritten samples. This PR needs some more work before review.

@dbolduc dbolduc marked this pull request as ready for review February 23, 2023 23:23
@dbolduc dbolduc merged commit 32d66ea into googleapis:main Feb 24, 2023
@dbolduc dbolduc deleted the relocate-iam-v1 branch February 24, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: iam Issues related to the Identity and Access Management API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants