impl: fix updating of strip_prefix in renovate.sh #10946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`renovate.sh` knew that the editable `bazel/google_cloud_cpp_deps.bzl` elements were terminated by the "sha256" field ... until they weren't. (See "canonicalize the ordering of urls/sha256/strip_prefix fields" in googleapis#10851.) The new sed script is just as fragile, but hopefully now a little more stable. Also update the order of the substitution commands to match the file, for just a little more clarity.
Codecov ReportBase: 93.64% // Head: 93.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10946 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 1717 1717
Lines 154890 154890
=======================================
+ Hits 145045 145054 +9
+ Misses 9845 9836 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renovate.shknew that the editablebazel/google_cloud_cpp_deps.bzlelements were terminated by the "sha256" field ... until they weren't. (See "canonicalize the ordering of urls/sha256/strip_prefix fields" in #10851.)The new sed script is just as fragile, but hopefully now a little more stable.
Also update the order of the substitution commands to match the file, for just a little more clarity.
This change is