Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(bigquery): use versioned clients in samples #11329

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Apr 20, 2023

Fixes #10170


This change is Reviewable

@product-auto-label product-auto-label bot added api: bigquery Issues related to the BigQuery API. samples Issues that are directly related to samples. labels Apr 20, 2023
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (43ea418) 93.73% compared to head (c880ad8) 93.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11329      +/-   ##
==========================================
- Coverage   93.73%   93.73%   -0.01%     
==========================================
  Files        1792     1792              
  Lines      160022   160022              
==========================================
- Hits       149998   149993       -5     
- Misses      10024    10029       +5     

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc marked this pull request as ready for review April 20, 2023 08:29
@dbolduc dbolduc requested a review from a team as a code owner April 20, 2023 08:29
@dbolduc dbolduc merged commit 95cb416 into googleapis:main Apr 20, 2023
@dbolduc dbolduc deleted the bigquery-versioned-samples branch April 20, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support clients for multiple versions of the same GCP service
2 participants