fix(storage): support per-request options #11445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the `rest_internal::RestClient` implementation we were not respecting some per-request options. This changes the implementation of `rest_internal::RestClient` to use the options provided in `rest_internal::RestContext`. That seemed cleaner than using the options span. I gave myself some leeway by adding default constructors to some `storage::internal::*Request` classes. It makes it easier to write unit tests where the contents of the request are uninteresting. I included an integration test in `rest_internal::RestClient`.
product-auto-label
bot
added
the
api: storage
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11445 +/- ##
==========================================
+ Coverage 93.78% 93.80% +0.02%
==========================================
Files 1805 1805
Lines 162337 162930 +593
==========================================
+ Hits 152244 152838 +594
+ Misses 10093 10092 -1
☔ View full report in Codecov by Sentry. |
devbww
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
rest_internal::RestClientimplementation we were not respecting some per-request options. This changes the implementation ofrest_internal::RestClientto use the options provided inrest_internal::RestContext. That seemed cleaner than using the options span.I gave myself some leeway by adding default constructors to some
storage::internal::*Requestclasses. It makes it easier to write unit tests where the contents of the request are uninteresting.I included an integration test in
rest_internal::RestClient.Fixes #11441
This change is