Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update set up workstation how-to #11478

Merged
merged 6 commits into from
May 8, 2023

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented May 2, 2023

  • Update doc to handle x86_64 (uname -p produces unknown for x86_64 on my VM)
  • Add sudo before running the install google sdk script so the mkdir commands can create directories
  • Add a note about installing clangtidy in newer versions of ubuntu

This change is Reviewable

@alevenberg alevenberg requested a review from a team as a code owner May 2, 2023 22:19
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we should be removing some existing code at the same time?

ci/install-cloud-sdk.sh Outdated Show resolved Hide resolved
@coryan
Copy link
Contributor

coryan commented May 3, 2023

FYI, we use conventional commits: https://www.conventionalcommits.org/en/v1.0.0/ The title for this PR should be something like:

ci: update script to install gcloud CLI

or

docs: update set up workstation how-to

The fact that both are possible suggests they could be two separate PRs. But for small changes like this mixing two things is not the end of the world.

@alevenberg alevenberg self-assigned this May 3, 2023
@alevenberg alevenberg changed the title Update script and docs for setup docs: update set up workstation how-to May 3, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f2f8665) 93.81% compared to head (6135814) 93.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11478   +/-   ##
=======================================
  Coverage   93.81%   93.82%           
=======================================
  Files        1808     1808           
  Lines      163596   163596           
=======================================
+ Hits       153481   153487    +6     
+ Misses      10115    10109    -6     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

ci/install-cloud-sdk.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alevenberg)

@alevenberg alevenberg merged commit 3516b14 into googleapis:main May 8, 2023
@alevenberg alevenberg deleted the alevenb/docs branch May 8, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants