-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update set up workstation how-to #11478
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we should be removing some existing code at the same time?
FYI, we use conventional commits: https://www.conventionalcommits.org/en/v1.0.0/ The title for this PR should be something like:
or
The fact that both are possible suggests they could be two separate PRs. But for small changes like this mixing two things is not the end of the world. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #11478 +/- ##
=======================================
Coverage 93.81% 93.82%
=======================================
Files 1808 1808
Lines 163596 163596
=======================================
+ Hits 153481 153487 +6
+ Misses 10115 10109 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alevenberg)
This change is