Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): increase backoff from 1.3 to 4.0 #12306

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Aug 3, 2023

Fixes #12328

This change is Reviewable

@alevenberg alevenberg requested a review from a team as a code owner August 3, 2023 18:22
@alevenberg alevenberg temporarily deployed to internal August 3, 2023 18:22 — with GitHub Actions Inactive
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Aug 3, 2023
@alevenberg alevenberg added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Aug 3, 2023
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a feat. Maybe it is a fix? Although I have no idea what we are fixing...

Maybe put the motivation for this change in the PR description?

@alevenberg alevenberg changed the title feat(pubsub): increase backoff from 1.3 to 4.0 fix(pubsub): increase backoff from 1.3 to 4.0 Aug 3, 2023
@alevenberg
Copy link
Member Author

Discussed with Darren.

Closing since the motivating change is due to how the GAPIC libraries implement exponential backoff.

C++ does not use that implementation.

@alevenberg alevenberg closed this Aug 3, 2023
@alevenberg alevenberg reopened this Aug 7, 2023
@alevenberg alevenberg temporarily deployed to internal August 7, 2023 16:19 — with GitHub Actions Inactive
@alevenberg
Copy link
Member Author

Re-opening, the pub/sub team will create an issue motivating the change

@alevenberg alevenberg temporarily deployed to internal August 7, 2023 16:35 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2fc5960) 93.59% compared to head (172501e) 93.59%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12306   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files        2026     2026           
  Lines      179055   179055           
=======================================
+ Hits       167578   167581    +3     
+ Misses      11477    11474    -3     
Files Changed Coverage Δ
google/cloud/pubsub/internal/defaults.cc 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg alevenberg temporarily deployed to internal August 7, 2023 17:22 — with GitHub Actions Inactive
@alevenberg alevenberg removed the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Aug 7, 2023
@alevenberg alevenberg merged commit 3710ca6 into googleapis:main Aug 14, 2023
52 checks passed
@alevenberg alevenberg deleted the pubsub-increase-exp-backoff branch August 14, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default retry settings result in too-frequent retries for Resource Exhausted errors
3 participants