Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): retry loops signal via error info #12313

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Aug 4, 2023

Use the Status::error_info() to signal details about why a retry loop fails. We were using the contents of the message.

Fixes #12303


This change is Reviewable

Use the `Status::error_info()` to signal details about why a retry loop
fails. We were using the contents of the message.
@coryan coryan temporarily deployed to internal August 4, 2023 03:53 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (449bf80) 93.49% compared to head (0e30221) 93.50%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #12313    +/-   ##
========================================
  Coverage   93.49%   93.50%            
========================================
  Files        2014     2014            
  Lines      178020   178261   +241     
========================================
+ Hits       166441   166677   +236     
- Misses      11579    11584     +5     
Files Changed Coverage Δ
google/cloud/internal/retry_loop_helpers.h 100.00% <ø> (ø)
google/cloud/status.h 100.00% <ø> (ø)
..._tests/tests/golden_thing_admin_connection_test.cc 99.59% <100.00%> (+<0.01%) ⬆️
...s/tests/golden_thing_admin_rest_connection_test.cc 99.60% <100.00%> (+<0.01%) ⬆️
google/cloud/internal/async_rest_retry_loop.h 100.00% <100.00%> (ø)
...oogle/cloud/internal/async_rest_retry_loop_test.cc 98.60% <100.00%> (-0.64%) ⬇️
google/cloud/internal/async_retry_loop.h 100.00% <100.00%> (ø)
google/cloud/internal/async_retry_loop_test.cc 98.85% <100.00%> (-0.65%) ⬇️
google/cloud/internal/rest_retry_loop.h 100.00% <100.00%> (ø)
google/cloud/internal/rest_retry_loop_test.cc 97.48% <100.00%> (+0.18%) ⬆️
... and 9 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan temporarily deployed to internal August 4, 2023 13:02 — with GitHub Actions Inactive
@coryan coryan marked this pull request as ready for review August 4, 2023 14:04
@coryan coryan requested a review from a team as a code owner August 4, 2023 14:04
google/cloud/internal/retry_loop_helpers.cc Outdated Show resolved Hide resolved
google/cloud/internal/retry_loop_helpers.h Outdated Show resolved Hide resolved
google/cloud/internal/retry_loop_helpers.h Outdated Show resolved Hide resolved
@coryan coryan temporarily deployed to internal August 4, 2023 15:32 — with GitHub Actions Inactive
@coryan coryan enabled auto-merge (squash) August 4, 2023 15:36
@coryan coryan merged commit e31f2b2 into googleapis:main Aug 4, 2023
52 checks passed
@coryan coryan deleted the feat-better-retry-loop-error-messages branch August 4, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve retry loop(s) errors
2 participants