fix(common): gRPC alarms require more locking #12406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out `grpc::Alarm` is not thread-safe. The documentation is about to say so, and a future implementation will trigger more faults in our code.
drfloob
reviewed
Aug 17, 2023
drfloob
reviewed
Aug 17, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #12406 +/- ##
=======================================
Coverage 93.62% 93.62%
=======================================
Files 2032 2032
Lines 179889 179899 +10
=======================================
+ Hits 168421 168431 +10
Misses 11468 11468
☔ View full report in Codecov by Sentry. |
|
Ping. |
dbolduc
approved these changes
Aug 18, 2023
coryan
added a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Aug 18, 2023
Turns out `grpc::Alarm` is not thread-safe. The documentation is about to say so, and a future implementation will trigger more faults in our code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out
grpc::Alarmis not thread-safe. The documentation is about to say so, and a future implementation will trigger more faults in our code.This change is