feat(common): add Options::set<>() && overload
#12424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our examples and documentation we use expressions like
`Options{}.set<A>(a).set<B>(b)` and then pass the result by value.
To get a move constructor out of such expressions the `set<>` functions
must have a `&&` overload.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #12424 +/- ##
==========================================
- Coverage 93.63% 93.62% -0.01%
==========================================
Files 2035 2035
Lines 180250 180220 -30
==========================================
- Hits 168778 168734 -44
- Misses 11472 11486 +14
☔ View full report in Codecov by Sentry. |
devbww
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our examples and documentation we use expressions like
Options{}.set<A>(a).set<B>(b)and then pass the result by value. To get a move constructor out of such expressions theset<>functions must have a&&overload.This change is