Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): another Bucket CRUD field #12842

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 6, 2023

This time, the Bucket.auto_class() gains terminal_storage_class, and OUTPUT_ONLY terminate_storage_class_update fields. Only interesting for completeness sake.

Fixes #12658


This change is Reviewable

@coryan coryan temporarily deployed to internal October 6, 2023 23:22 — with GitHub Actions Inactive
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Oct 6, 2023
@coryan
Copy link
Contributor Author

coryan commented Oct 6, 2023

/FYI @cojenco

@coryan coryan temporarily deployed to internal October 6, 2023 23:57 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6380988) 93.55% compared to head (65693f6) 93.55%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12842      +/-   ##
==========================================
- Coverage   93.55%   93.55%   -0.01%     
==========================================
  Files        2074     2074              
  Lines      180452   180513      +61     
==========================================
+ Hits       168815   168871      +56     
- Misses      11637    11642       +5     
Files Coverage Δ
google/cloud/storage/bucket_metadata.cc 99.09% <100.00%> (+<0.01%) ⬆️
google/cloud/storage/bucket_metadata_test.cc 99.67% <100.00%> (+<0.01%) ⬆️
...e/cloud/storage/internal/bucket_metadata_parser.cc 98.44% <100.00%> (+0.01%) ⬆️
...ud/storage/internal/grpc/bucket_metadata_parser.cc 92.67% <100.00%> (-0.15%) ⬇️
...orage/internal/grpc/bucket_metadata_parser_test.cc 99.47% <100.00%> (+<0.01%) ⬆️
...torage/internal/grpc/bucket_request_parser_test.cc 100.00% <100.00%> (ø)
google/cloud/storage/bucket_autoclass.cc 87.50% <75.00%> (-12.50%) ⬇️
google/cloud/storage/bucket_autoclass.h 93.33% <90.90%> (-6.67%) ⬇️
...orage/examples/storage_bucket_autoclass_samples.cc 91.11% <91.66%> (+0.06%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This time, the `Bucket.auto_class()` gains `terminal_storage_class`, and
`OUTPUT_ONLY` `terminate_storage_class_update` fields. Only interesting
for completeness sake.
@coryan coryan force-pushed the feat-storage-support-terminal-storage-class branch from 3aba1bd to 3063975 Compare October 7, 2023 16:42
@coryan coryan temporarily deployed to internal October 7, 2023 16:42 — with GitHub Actions Inactive
@coryan coryan marked this pull request as ready for review October 9, 2023 15:43
@coryan coryan requested a review from a team as a code owner October 9, 2023 15:43
auto const object_name =
examples::MakeRandomObjectName(generator, "object-") + ".txt";
auto client = gcs::Client();

std::cout << "\nCreating buckets to run the example:"
<< "\nEnabled Autoclass: " << bucket_name_enabled
<< "\nDisabled Autoclass: " << bucket_name_disabled << std::endl;
<< "\nDisabled Autoclass: " << bucket_name_disabled
<< "\nArchive Autclass: " << bucket_name_archive << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a/Autclass/Autoclass/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

@coryan coryan temporarily deployed to internal October 9, 2023 15:55 — with GitHub Actions Inactive
@coryan coryan enabled auto-merge (squash) October 9, 2023 15:55
@coryan coryan merged commit 1d94ab4 into googleapis:main Oct 9, 2023
54 checks passed
@coryan coryan deleted the feat-storage-support-terminal-storage-class branch October 9, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage: add support for Autoclass v2.1
2 participants