Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otel): add Makefile #13177

Merged
merged 2 commits into from
Nov 21, 2023
Merged

feat(otel): add Makefile #13177

merged 2 commits into from
Nov 21, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Nov 21, 2023

Fixes #10795

Add a Makefile to the OpenTelemetry exporter library quickstart, to show how to build with make(1).

Also, now that opentelemetry-cpp installs its own opentelemetry_*.pc modules with proper compiler definitions, we no longer need to define HAVE_ABSEIL for them in our code. Yay.


This change is Reviewable

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc482f0) 92.99% compared to head (a27fb8c) 92.99%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13177      +/-   ##
==========================================
- Coverage   92.99%   92.99%   -0.01%     
==========================================
  Files        2138     2138              
  Lines      185971   185971              
==========================================
- Hits       172952   172949       -3     
- Misses      13019    13022       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review November 21, 2023 20:45
@dbolduc dbolduc requested a review from a team as a code owner November 21, 2023 20:45

# Configuration variables to compile and link against the Google Cloud
# OpenTelemetry Exporter library and the Google Cloud Storage client.
CLIENT_MODULE := google_cloud_cpp_opentelemetry google_cloud_cpp_storage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/CLIENT_MODULE/EXAMPLE_MODULES/ ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@dbolduc dbolduc enabled auto-merge (squash) November 21, 2023 21:26
@dbolduc dbolduc merged commit 0ac2d5d into googleapis:main Nov 21, 2023
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installed google-cloud-cpp w/ OpenTelemetry usable from make(1)
3 participants