Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): pass by reference explictly #13220

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Dec 4, 2023

This change is Reviewable

@alevenberg alevenberg requested a review from a team as a code owner December 4, 2023 15:43
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Dec 4, 2023
@coryan coryan added the gha:full-build Trigger a full build in GHA label Dec 4, 2023
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set a label to get full builds from Windows

google/cloud/pubsub/internal/tracing_batch_sink_test.cc Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18c9048) 92.99% compared to head (61df646) 92.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13220   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files        2135     2135           
  Lines      186300   186300           
=======================================
+ Hits       173246   173250    +4     
+ Misses      13054    13050    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg alevenberg merged commit 1e5f094 into googleapis:main Dec 4, 2023
81 checks passed
@alevenberg alevenberg deleted the fix-2 branch December 4, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. gha:full-build Trigger a full build in GHA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants