Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): support Bucket soft-delete metadata #13623

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 16, 2024

With this change applications can query and update the soft-delete policy for a Google Cloud Storage bucket. The change includes some examples, these examples run against production and the emulator and pass in both cases.

Part of the work for #13575


This change is Reviewable

With this change applications can query and update the soft-delete
policy for a Google Cloud Storage bucket. The change includes some
examples, these examples run against production and the emulator and
pass in both cases.
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4d986f1) 93.26% compared to head (25a6a81) 93.27%.
Report is 1 commits behind head on main.

Files Patch % Lines
...age/examples/storage_bucket_soft_delete_samples.cc 94.80% 4 Missing ⚠️
...ud/storage/internal/grpc/bucket_metadata_parser.cc 94.11% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #13623    +/-   ##
========================================
  Coverage   93.26%   93.27%            
========================================
  Files        2223     2227     +4     
  Lines      193466   193714   +248     
========================================
+ Hits       180440   180686   +246     
- Misses      13026    13028     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review February 16, 2024 20:00
@coryan coryan requested a review from a team as a code owner February 16, 2024 20:00
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan merged commit ec661c0 into googleapis:main Feb 20, 2024
61 checks passed
@coryan coryan deleted the feat-storage-bucket-soft-delete-policy branch February 20, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants