fix(spanner): correct use of Interval offset in Timestamp addition #14121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding an `Interval` to a `Timestamp`+time-zone, the offset should be interpreted as an absolute value rather than a civil one. (This is a poor choice in my opinion, but so be it.) Update the test case, which now has to use a "1 day" interval to show the difference between `Add(ts, "1 day", tz)` and `Add(ts, "24 hours", tz)` over a civil-time discontinuity. Add a new test based upon the postgresql.org examples, one of which would have demonstrated the original problem.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14121 +/- ##
==========================================
- Coverage 93.78% 93.24% -0.55%
==========================================
Files 2290 2203 -87
Lines 199313 188898 -10415
==========================================
- Hits 186934 176129 -10805
- Misses 12379 12769 +390 ☔ View full report in Codecov by Sentry. |
scotthart
approved these changes
May 3, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @devbww)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding an
Intervalto aTimestamp+time-zone, the offset should be interpreted as an absolute value rather than a civil one. (This is a poor choice in my opinion, but so be it.)Update the test case, which now has to use a "1 day" interval to show the difference between
Add(ts, "1 day", tz)andAdd(ts, "24 hours", tz)over a civil-time discontinuity.Add a new test based upon the postgresql.org examples, one of which would have demonstrated the original problem.
This change is