Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): out of range access in handle cleanup #14134

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented May 6, 2024

Fixes #14132


This change is Reviewable

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.79%. Comparing base (125fc25) to head (3d6ab39).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14134   +/-   ##
=======================================
  Coverage   93.78%   93.79%           
=======================================
  Files        2290     2290           
  Lines      199475   199507   +32     
=======================================
+ Hits       187078   187122   +44     
+ Misses      12397    12385   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review May 6, 2024 17:34
@coryan coryan requested a review from a team as a code owner May 6, 2024 17:34
@coryan coryan merged commit fdc1eef into googleapis:main May 6, 2024
63 checks passed
@coryan coryan deleted the fix-storage-correct-cleanup-on-handle-factory branch May 6, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential crash in PooledCurlHandleFactory
2 participants