Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pubsub): include admin options #14359

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jun 24, 2024

Also part of the work for #14207

The admin options are called google-cloud-{library}-options. They were not being included in these handwritten option dox.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.19%. Comparing base (cac2123) to head (b63f1c7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14359   +/-   ##
=======================================
  Coverage   93.19%   93.19%           
=======================================
  Files        2191     2191           
  Lines      192367   192367           
=======================================
  Hits       179284   179284           
  Misses      13083    13083           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review June 24, 2024 13:09
@dbolduc dbolduc requested a review from a team as a code owner June 24, 2024 13:09
@dbolduc dbolduc merged commit 1b2db9a into googleapis:main Jun 24, 2024
65 checks passed
@dbolduc dbolduc deleted the docs-pubsub-admin-options branch June 24, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants