Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otel): capture error message in traces (again) #14389

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jun 27, 2024

With this PR, applications that enable OpenTelemetry tracing, and use the Cloud Trace exporter, will be able to see error messages in the UI.

This change also makes it easier to filter client library errors only in the Cloud Trace UI with:

label:gl-cpp.error.message

Other attributes use the domain: gcloud.error.*. I will update them to use gl-cpp.error.* in a follow up PR.

I also think we should change gl-cpp.status_code from an int to a human readable string. I will address that in a follow up PR.


This change is Reviewable

@dbolduc dbolduc marked this pull request as ready for review June 27, 2024 21:09
@dbolduc dbolduc requested a review from a team as a code owner June 27, 2024 21:09
@dbolduc dbolduc enabled auto-merge (squash) June 27, 2024 21:11
@dbolduc dbolduc merged commit 36f6bd4 into googleapis:main Jun 27, 2024
66 checks passed
@dbolduc dbolduc deleted the otel-wokraround-cloud-trace-ui branch June 27, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants