Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): censor Bearer tokens over HTTP/2 #14564

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jul 25, 2024

Our logs censored Bearer tokens over HTTP/1.x. These tokens appear in the "info" callbacks, not the "header" callbacks for HTTP/2, and we failed to censor the tokens in that case.

This change is Reviewable

@coryan coryan marked this pull request as ready for review July 25, 2024 12:55
@coryan coryan requested a review from a team as a code owner July 25, 2024 12:55
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.59%. Comparing base (424ca3c) to head (5d132a4).
Report is 97 commits behind head on main.

Files with missing lines Patch % Lines
google/cloud/internal/curl_wrappers_test.cc 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14564   +/-   ##
=======================================
  Coverage   93.58%   93.59%           
=======================================
  Files        2318     2318           
  Lines      206995   207000    +5     
=======================================
+ Hits       193723   193733   +10     
+ Misses      13272    13267    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan merged commit e559c9a into googleapis:main Jul 25, 2024
67 checks passed
@coryan coryan deleted the fix-common-censor-bearer-tokens-over-HTTP2 branch July 25, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants