Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(generator): include request in async streaming RPC logs #14565

Merged
merged 3 commits into from
Jul 25, 2024
Merged

feat(generator): include request in async streaming RPC logs #14565

merged 3 commits into from
Jul 25, 2024

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jul 25, 2024 •
edited
Loading

This change is Reviewable

@coryan coryan marked this pull request as ready for review July 25, 2024 13:34
@coryan coryan requested review from a team as code owners July 25, 2024 13:34
@codecov Codecov
Copy link

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.58%. Comparing base (424ca3c) to head (8bbe7c1).
Report is 97 commits behind head on main.

Files with missing lines Patch % Lines
google/cloud/internal/curl_wrappers_test.cc 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #14565   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files        2318     2318           
  Lines      206995   207002    +7     
=======================================
+ Hits       193723   193732    +9     
+ Misses      13272    13270    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

scotthart
scotthart approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan merged commit ad1d045 into googleapis:main Jul 25, 2024
67 checks passed
@coryan coryan deleted the feat-generator-include-request-in-streaming-read-logs branch July 25, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotthart scotthart scotthart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coryan @scotthart