docs: update mock LRO tips #14609
Merged
docs: update mock LRO tips #14609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14609 +/- ##
=======================================
Coverage 93.59% 93.59%
=======================================
Files 2316 2316
Lines 207108 207108
=======================================
Hits 193840 193840
Misses 13268 13268 ☔ View full report in Codecov by Sentry. |
dbolduc
force-pushed
the
mock-lro-disambiguate-comment
branch
from
af0e660
to
7b3c0c3
Compare
scotthart
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Reviewed 1 of 264 files at r1, all commit messages.
Reviewable status: 1 of 264 files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since dropping the
ExperimentalTagwe can no longer rely on the parameter count to disambiguate the typical LRO call.So show how to match on the parameter type as a hint.
This change is