fix: quickstarts build with bazel #14633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14633 +/- ##
==========================================
- Coverage 93.59% 93.59% -0.01%
==========================================
Files 2316 2316
Lines 207122 207122
==========================================
- Hits 193855 193854 -1
- Misses 13267 13268 +1 ☔ View full report in Codecov by Sentry. |
scotthart
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Reviewed 6 of 139 files at r1.
Reviewable status: 6 of 139 files reviewed, all discussions resolved
cuiy0006
pushed a commit
to cuiy0006/google-cloud-cpp
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14625
Our quickstarts should probably support both bazel and bzlmod.... But right now they support neither. So make them work with plain old bazel.
This change is