Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compute): add missing services instant_snapshots and region_instant_snapshots #14647

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

scotthart
Copy link
Member

@scotthart scotthart commented Aug 15, 2024

The protos for these services were added previously, but generating the service code was overlooked.


This change is Reviewable

@scotthart scotthart requested a review from a team as a code owner August 15, 2024 22:45
@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (bdd3e73) to head (ed106f1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14647      +/-   ##
==========================================
- Coverage   93.59%   93.59%   -0.01%     
==========================================
  Files        2316     2316              
  Lines      207122   207122              
==========================================
- Hits       193849   193847       -2     
- Misses      13273    13275       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc changed the title impl(compute): add missing services instant_snapshots and region_instant_snapshots feat(compute): add missing services instant_snapshots and region_instant_snapshots Aug 15, 2024
@scotthart scotthart merged commit cfdeff8 into googleapis:main Aug 15, 2024
69 checks passed
cuiy0006 pushed a commit to cuiy0006/google-cloud-cpp that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants