Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(mixin): refactor mixin utils to use HttpRule #14723

Merged
merged 7 commits into from
Sep 23, 2024

Conversation

cuiy0006
Copy link
Collaborator

@cuiy0006 cuiy0006 commented Sep 20, 2024

Refactor mixin utils to use HttpRule as http overrides.


This change is Reviewable

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.50%. Comparing base (fbc2aa6) to head (ad44e99).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
generator/internal/http_option_utils.cc 90.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14723      +/-   ##
==========================================
- Coverage   93.50%   93.50%   -0.01%     
==========================================
  Files        2323     2323              
  Lines      207947   207939       -8     
==========================================
- Hits       194440   194432       -8     
  Misses      13507    13507              
Flag Coverage Δ
93.50% <97.67%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuiy0006 cuiy0006 marked this pull request as ready for review September 20, 2024 18:16
@cuiy0006 cuiy0006 requested a review from a team as a code owner September 20, 2024 18:16
generator/internal/mixin_utils.cc Outdated Show resolved Hide resolved
generator/internal/mixin_utils.cc Outdated Show resolved Hide resolved
generator/internal/mixin_utils.cc Outdated Show resolved Hide resolved
generator/internal/mixin_utils.cc Show resolved Hide resolved
generator/internal/mixin_utils_test.cc Outdated Show resolved Hide resolved
generator/internal/mixin_utils_test.cc Outdated Show resolved Hide resolved
generator/internal/mixin_utils_test.cc Outdated Show resolved Hide resolved
generator/internal/mixin_utils_test.cc Outdated Show resolved Hide resolved
generator/internal/mixin_utils_test.cc Show resolved Hide resolved
generator/internal/mixin_utils.cc Show resolved Hide resolved
generator/internal/mixin_utils.cc Outdated Show resolved Hide resolved
generator/internal/mixin_utils_test.cc Outdated Show resolved Hide resolved
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

generator/internal/mixin_utils_test.cc Outdated Show resolved Hide resolved
generator/internal/mixin_utils_test.cc Show resolved Hide resolved
generator/internal/mixin_utils_test.cc Outdated Show resolved Hide resolved
@cuiy0006 cuiy0006 enabled auto-merge (squash) September 23, 2024 20:37
@cuiy0006 cuiy0006 merged commit 6d70fe8 into googleapis:main Sep 23, 2024
71 checks passed
@cuiy0006 cuiy0006 deleted the refactor-mixin-http-override branch September 23, 2024 21:13
@cuiy0006 cuiy0006 linked an issue Sep 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support google.cloud.location.Locations and maybe other mixins
2 participants