Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl: revert addition of generativelanguage #14731

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

scotthart
Copy link
Member

@scotthart scotthart commented Sep 25, 2024

This library is not yet ready to be released as part of this repo.

fixes #14702


This change is Reviewable

Copy link

snippet-bot bot commented Sep 25, 2024

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.45%. Comparing base (fded927) to head (cf6478a).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14731   +/-   ##
=======================================
  Coverage   93.45%   93.45%           
=======================================
  Files        2323     2323           
  Lines      208070   208070           
=======================================
+ Hits       194449   194452    +3     
+ Misses      13621    13618    -3     
Flag Coverage Δ
93.45% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated
@@ -8,11 +8,6 @@ breaking changes in the upcoming 3.x release. This release is scheduled for

### New Libraries
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove section header

Copy link
Member Author

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 89 files reviewed, 1 unresolved discussion (waiting on @dbolduc)


CHANGELOG.md line 9 at r2 (raw file):

Previously, dbolduc (Darren Bolduc) wrote…

Remove section header

Done.

@scotthart scotthart enabled auto-merge (squash) September 26, 2024 15:56
@scotthart scotthart merged commit 1a7947d into googleapis:main Sep 26, 2024
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure CI to execute generativelanguage sample
2 participants