cleanup(bigtable)!: remove async functions that take CompletionQueue as a param
#6921
Conversation
googlebot
added
the
cla: yes
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
| identically named functions which do not require a `CompletionQueue&`. If | ||
| users absolutely require a custom `CompletionQueue`, one can be supplied to | ||
| the `DataClient` used to construct the `Table`, via | ||
| `ClientOptions::DisableBackgroundThreads(CompletionQueue const&)`. |
There was a problem hiding this comment.
- Is this even worth saying?
- The change to prefer
Options>ClientOptionswill be done in this release. I am making a mental note to come back and updateCHANGELOG.mdaccordingly
There was a problem hiding this comment.
In general, I think "You cannot use Foo() anymore, use Bar() instead" is more friendly/useful than "Foo() was removed."
It is also better to assume that folks have not memorized our reference manual, so they may not be familiar with every option in the library.
With those caveats, pointing folks to the recommended way to do things is the "Right Thing":tm:
There was a problem hiding this comment.
The change is Okay as-is, we just need to update the CHANGELOG on the PRs where we start recommending Options{} instead.
Codecov Report
@@ Coverage Diff @@
## main #6921 +/- ##
=======================================
Coverage 94.55% 94.56%
=======================================
Files 1278 1278
Lines 114431 114421 -10
=======================================
Hits 108204 108204
+ Misses 6227 6217 -10
Continue to review full report at Codecov.
|
Fixes #2567
Note: this leaves a lot of
*Impl()'s that are called only once. I will refactor these in a subsequent PR.This change is